Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore and/or report invalid package names in github security advisories #209

Closed
Ocramius opened this issue Oct 20, 2020 · 6 comments · Fixed by #236
Closed

Ignore and/or report invalid package names in github security advisories #209

Ocramius opened this issue Oct 20, 2020 · 6 comments · Fixed by #236
Labels

Comments

@Ocramius
Copy link
Member

See https://github.com/Roave/SecurityAdvisories/blob/2762ddacb0bf083e0bdc53eab51361fddced402d/composer.json#L200-L201

GHSA-6gw4-x63h-5499 caused this to break (I had to contact the folks at @Sylius directly to get it fixed).

Basically, sylius\sylius was entered instead of sylius/sylius.

I think we can do two things:

  1. fail the build completely (good first step)
  2. ignore the packages and raise a warning (problematic, as we won't really notice it)
@Ocramius Ocramius added the bug label Oct 20, 2020
@slash3b
Copy link
Contributor

slash3b commented Oct 30, 2020

do you think it makes sense to implement a simple validator-corrector for package name ?

@Ocramius
Copy link
Member Author

Ocramius commented Nov 1, 2020

Thank you, @slash3b! \o/

@Ocramius
Copy link
Member Author

Ocramius commented Nov 1, 2020

do you think it makes sense to implement a simple validator-corrector for package name ?

This is already part of upstream composer tooling - I'm wondering if we should somehow notify github security about this problem in their feeds 🤔

@slash3b
Copy link
Contributor

slash3b commented Nov 2, 2020

thank you, @Ocramius ^^

I did ask the one who published advisory to edit it. Waiting for a reply.

@slash3b
Copy link
Contributor

slash3b commented Nov 7, 2020

It was corrected. We are good to go \o/

GHSA-6gw4-x63h-5499

@Ocramius
Copy link
Member Author

Ocramius commented Nov 7, 2020

Yup, the problem is that this will happen again 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants