Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with a Psalm baseline gives misleading results, with an inflated MSI score #484

Open
bdsl opened this issue Nov 17, 2023 · 1 comment

Comments

@bdsl
Copy link

bdsl commented Nov 17, 2023

I started using infection on a project via this plugin, but eventually after doing some investigations to learn exactly how Psalm was killing some mutants I found that mutants are shown as killed by Psalm errors even if those errors are in the project's Psalm baseline file, which means that Psalm does not report any error when it is run after the mutation is applied.

I don't know if it's feasible to make this plugin work with a baseline, but it is feasible to try to prevent usage with a baseline, by adding a warning about this issue to the readme and/or by making the plugin detect the presence of a baseline and refuse to run.

I'd be happy to make a PR to implement one or both of those changes if maintainers here think that would be helpful.

@Ocramius
Copy link
Member

IMO I'd start with a small functional test containing an obvious baseline entry: from there, we could discuss approaches 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants