fixed a bug where a packet less than 16 bytes long would crash the se…

…rver
Roave · Jan 5, 2012 · 1531091 · 1531091
1 parent 1985b08
commit 1531091
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/data-handler.js b/lib/data-handler.js
@@ -40,7 +40,7 @@ exports.fromBuffer = function(pduBuffer, splitBuffer) {
     // something wrong, and we should probably emit an error from here instead
     // of returning false (TODO)
     if (pduBuffer.length < 16) {
-        return false;
+        throw "not enough data";
     }
 
     bufferPosition = 0;

diff --git a/lib/server-connection.js b/lib/server-connection.js
@@ -90,6 +90,7 @@ var serverConnection = function(socket, server, closeConnectionServerCallback, c
         } catch (err) {
             self.generic_nack();
             self.emit('error', client, err);
+            return;
         }
 
         pdus = parsedBuffer.pdus;