Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash validation is susceptible to timing attacks #2

Closed
lcobucci opened this issue Mar 12, 2017 · 2 comments
Closed

Hash validation is susceptible to timing attacks #2

lcobucci opened this issue Mar 12, 2017 · 2 comments

Comments

@lcobucci
Copy link

lcobucci commented Mar 12, 2017 •
edited

Due to string comparison, please use hash_equals() instead.
@RobDWaller
Copy link
Owner

I hadn't even thought about Timing Attacks in this case, bit of a school boy, I'll fix.

@RobDWaller
Copy link
Owner

This should be resolved now. Thanks.

@k-msalehi k-msalehi mentioned this issue Aug 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcobucci @RobDWaller