-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account name in MS Authenticator #92
Comments
When I scan the QR code from the demo MS Authenticator shows issuer just fine? Does the demo work for you? |
Then I guess that's something MS Authenticator does. Try replacing the |
Yes it seems the @ symbol is the one triggering this behaviour in MS authenticator. Only strange thing is I have other accounts on my MS authenticator with both the account name and email address showing correctly. |
Then have a look at the QR codes you used for those accounts and spot the difference. Did you try my replace/escape suggestions? |
Yes I tried those and it works to display the account name although the email address will be displayed as it is (i.e. demo%40outlook.com, demo[at]outlook.com). |
I'm sorry, but it seems to me that this is an MS Authenticator issue? |
yeah I think its down to individual OTP clients, if there is one secret you have that works perfectly and you can send us the secret otpauth:// URL (redacted of course) we can probably figure it out but otherwise I don't think there is much that can be done |
Here's the URL, hope this is what you need? |
only if that one displays correctly in MS Authenticator? |
This one does -- But please note that I have to replace the @ sign with [at] in order for the account name (RobThree TwoFactorAuth) to show on the MS authenticator. |
I'm afraid there's not much we can do in this matter. |
You can solve this by using the following format in the first parameter of your QR code generator; 'MyApp:UserEmail', e.g. |
Interesting, I was not aware this is part of the spec apparently https://docs.yubico.com/yesdk/users-manual/application-oath/uri-string-format.html Presumably there is nothing stopping you from passing |
Hi Rob Your 2FA is great. I also had problems to display the issuer. While analyzing your code of the TwoFactorAuth class I came across this link. I think the order of your values at Line 158 till 159 are not correct. If I rewrote them as follows and the issuer is shown in all 2FA apps tested (2FAS Auth, FreeOTP). Your code is TwoFactorAuth/lib/TwoFactorAuth.php Lines 157 to 162 in 098dce6
Code should be acc my opinion |
What you're proposing isn't (just) order, it changes the
However, it is explained in the label section to provide the issuer argument as well as in the label. So then you could just add the issuer to the Also if order would matter then the whole 'key=value' would be pointlessless; if order actually matters for a client then the client is not... 'very smart'. |
Can we close this issue? This would bring the total number of open issues to 0 🎉 ! |
You do the honors, you've worked hard enough for it 😉 |
Firstly, thanks for this library, very useful and easy to use.
When I initialize the class and specify a name ( i.e. $tfa = new TwoFactorAuth('My App'); ) MS Authenticator doesn't seem to apply this and uses the domain name of the email address as the account name on its authenticator app.
On the other hand, Google Authenticator works fine with this.
Any ideas?
The text was updated successfully, but these errors were encountered: