Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor getScreensize code #17

Closed
9 tasks done
RobTillaart opened this issue Nov 9, 2023 · 2 comments · Fixed by #18
Closed
9 tasks done

refactor getScreensize code #17

RobTillaart opened this issue Nov 9, 2023 · 2 comments · Fixed by #18
Assignees
@RobTillaart
Labels
enhancement New feature or request

Comments

@RobTillaart
Copy link
Owner

RobTillaart commented Nov 9, 2023 •
edited
Loading

  • bool getScreenSize(x, y, timeout = 100)
  • bool readCursorPosition(x, y, timeout = 100); // remove the "screen struct to make interface simpler
  • remove String class from readCursorPosition()
  • update readme
  • bump version number (==> 0.2.2)
  • update keywords.txt
  • _stream iso Serial
  • get access level right
    • x and y may not be writeable
    • ==> inline access functions ansi.screenWidth() + ansi.screenHeight()
  • check 9x9 screen . Minimal buffer 7?
@RobTillaart RobTillaart self-assigned this Nov 9, 2023
@RobTillaart RobTillaart added the enhancement New feature or request label Nov 9, 2023
@RobTillaart RobTillaart mentioned this issue Nov 9, 2023
Merged
@RobTillaart
Copy link
Owner Author

RobTillaart commented Nov 9, 2023 •
edited
Loading

(UNO, IDE 1.8.19)
Size ansi_performance: 2802 / 388 (pre-optimize)
Size ansi_screenSize.ino: 5032 / 375 (pre-optimize)

@RobTillaart RobTillaart mentioned this issue Nov 9, 2023
Merged
@RobTillaart
Copy link
Owner Author

RobTillaart commented Nov 9, 2023 •
edited
Loading

@chlordk
Created a refactored /optimized version (see #18

Size ansi_screenSize.ino: 5032 / 375 (pre-optimize)
Size ansi_screenSize.ino: 3674/ 368 (post-optimize)

@RobTillaart RobTillaart linked a pull request Nov 11, 2023 that will close this issue
refactor getScreenSize() #18
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobTillaart RobTillaart

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor getScreenSize() RobTillaart/ANSI
1 participant
@RobTillaart