Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove +nightly qualifier because of rust-toolchain #43

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Remove +nightly qualifier because of rust-toolchain #43

merged 1 commit into from
Apr 9, 2019

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Apr 1, 2019

This repository already has rust-toolchain file, but at the present in all build.sh there are inconsisency:

the first cargo invocation is without a qualifier
then the second cargo invocation is with +nightly qualifier

this means that build.sh will typically download the required toolchain, but then will use nightly. This might be a problem if nightly version is outdated.

@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   85.66%   85.66%           
=======================================
  Files          58       58           
  Lines        4451     4451           
=======================================
  Hits         3813     3813           
  Misses        638      638
Impacted Files Coverage Δ
cli/src/cmd/new.rs 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e93523...fd5b1b8. Read the comment docs.

@Robbepop
Copy link
Collaborator

Robbepop commented Apr 2, 2019

We should not forget to also change this in the rudimentary CLI tool.
Could you also pls rename the commit as noted in the contribution guidelines? :)

@pepyakin
Copy link
Contributor Author

pepyakin commented Apr 3, 2019

We should not forget to also change this in the rudimentary CLI tool.

What do you mean? If cli/src/cmd/new.rs then it is already in : )

Could you also pls rename the commit as noted in the contribution guidelines? :)

Sure, [chores]?

@Robbepop
Copy link
Collaborator

Robbepop commented Apr 3, 2019

We should not forget to also change this in the rudimentary CLI tool.

What do you mean? If cli/src/cmd/new.rs then it is already in : )

Could you also pls rename the commit as noted in the contribution guidelines? :)

Sure, [chores]?

Ah you are right I didn't see it!
[chores] sounds good for that but I have the feeling that in reality we are missing some further categories that we might want to add. Thanks!

@Robbepop Robbepop merged commit 7c64956 into use-ink:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants