Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why did the accessibility features are dropped in the recent version (1.5.x) of Dropkick? #219

Closed
vraa opened this issue Jul 1, 2014 · 3 comments

Comments

@vraa
Copy link

vraa commented Jul 1, 2014

Recently I'm tasked with making the 'fancy' select boxes accessible in my project. It's legacy code base, split into multiple tiny projects. In one projects, they were using Drop kick version 1.3.x and in another it was 1.5.x. Surprisingly, the older version (1.3.x) is very accessible and JAWS / screen readers didn't have problem reading the content in Dropkick.

But in latest version, I see the accessibility feature is explicitly turned off using aria-hidden=true.

Is there any specific reason to do that? Would be interested to know.

thanks.

@vraa vraa changed the title Why did the accessibility features are dropped in the recent version of Dropkick? Why did the accessibility features are dropped in the recent version (1.5.x) of Dropkick? Jul 1, 2014
@Robdel12
Copy link
Owner

Robdel12 commented Jul 1, 2014

I'm pretty sure 1.x was never accessible. I can't remember why or when the aria-hidden=truewas added either. I might be able to check it out. All of my time is dedicated to getting 2.0 out the door to replace 1.x.

If you can check out 2.0. It's fully accessible. And MUCH better.

@vraa
Copy link
Author

vraa commented Jul 2, 2014

@Robdel12 Thanks, I can see that the version 2 has many accessibility stuff baked in. For 1.5, I had to write code to override the DOM created by Dropkick to add aria features. Once 2.0 is out, will upgrade to it.

As feature request, it will be great if you could provide external hooks / or send us event so that we can run custom JavaScript code. For example, in order to add aria attributes, I had to run my custom function after certain milliseconds through setTimeout to let Dropkick do its work. But if Dropkick had provided an event mechanism, say, 'dropkick:done', I would have simply listened to that event and ran my custom code after Dropkick had done. The code will be much more clean and readable.

Thanks for your effort in developing Dropkick. 👍

@Robdel12
Copy link
Owner

Robdel12 commented Jul 2, 2014

Check out the API 2.0 offers. I think it should cover that :)

@Robdel12 Robdel12 closed this as completed Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants