Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 Object doesn't support this property or method #278

Closed
adrianosmond opened this issue Mar 16, 2015 · 3 comments
Closed

IE8 Object doesn't support this property or method #278

adrianosmond opened this issue Mar 16, 2015 · 3 comments

Comments

@adrianosmond
Copy link

I can't see browser support anywhere on here, but from other issues filed it looks like IE8 is in scope for DropKick?

I'm getting an "Object doesn't support this property or method" error in IE8 any time I select anything in DropKick. This is both in my own code and in the examples on http://robdel12.github.io/DropKick/

IE8 tells me this error is being caused by document.createEvent (which I don't think is supported in IE8). It looks like this is being called by the polyfill you've used for CustomEvent, which if it's this one as it looks like it is: https://github.com/krambuhl/custom-event-polyfill/blob/master/custom-event-polyfill.js, doesn't support IE8 (only IE9+).

@Robdel12
Copy link
Owner

Thanks @adrianosmond for the issue!

"I can't see browser support anywhere on here, but from other issues filed it looks like IE8 is in scope for DropKick?"

Yes, IE8 + is what we shoot to support. I've been trying to get a much better docs page going but I've been busy lately :/

I/we will definitely look into this today and hopefully ship a fix!

The really annoying thing is that polyfill is there just for Travis to build since PhantomJS doesn't support creating events. 😡 We need to look into something more solid.

@Robdel12
Copy link
Owner

@adrianosmond can you give this a shot on master? I'd like to verify before cutting 2.1.4

@Robdel12
Copy link
Owner

Closing this as it should have been fixed with d1b3485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants