Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Environment.observation_space requires the EnvParams, Environment.get_obs should too. #59

Open
keraJLi opened this issue Jun 20, 2023 · 0 comments

Comments

@keraJLi
Copy link
Contributor

keraJLi commented Jun 20, 2023

If params are designed to influence the observation space, then they should be available when generating an observation. Currently, the two functions in question are implemented like this

def get_obs(self, state: EnvState) -> chex.Array: pass
def observation_space(self, params: EnvParams): pass

I believe that this isn't a fatal issue, but I believe it would be more consistent when considering the overall design of the environment interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant