-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create bindings using KeyboardEvent#code value #33
Comments
I was under the impression that typically keyboard shortcuts are often standardized by key name rather than physical location on the keyboard. I checked both Mac and Windows via these support articles as an example.
Changing the locale does not change these shortcuts. This is more relevant for application shortcuts. But I can see the issue for something like a game. Is that what you are working on? Keystrokes uses key specifically so it is locale independent, so this is actually desired. Perhaps we need some sort of key code syntax though to allow you to choose. |
@vladdekhanov alright, I've added the ability to bind code names in bindings and combos. All you need to do is prefix the name with See the 1.5.0 release to try it out. Thanks for raising this one @vladdekhanov |
Thanks a lot and very appreciate your quick response. I've got a flu and wasn't available to response. Thank you for solution with |
Describe the bug
Library doesn't support
code
orwhich
property to make hotkey language agnostic. It compare event key by value due to works with only one keyboard layout.To Reproduce
Imagine you have keyboard with 2 layouts: native language and english (i.e. French and English).
Steps to reproduce the behavior:
Expected behavior
Library should work with
code
property (physical id of the button) and not with akey
(it contains value, changable thing), otherwise library would be used only for few countries where people use english as a native language.The text was updated successfully, but these errors were encountered: