Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump dev dependencies #1205

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

lukashroch
Copy link
Collaborator

@lukashroch lukashroch commented Feb 11, 2022

Bump dev dependencies altogether as there were some of the packages required simultaneous bump, which dependabot was failing on.

Edit: lint actions on node 10 were turned off in CI. Eslint & markdownlint don't support node10 anymore. And it's not really needed to do linting on whole matrix, it's just dev step so should in fact be enough to run just one time.

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #1205 (dbbc6d6) into master (bfba1e7) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   95.11%   95.10%   -0.02%     
==========================================
  Files         117      117              
  Lines        1126     1123       -3     
  Branches      129      128       -1     
==========================================
- Hits         1071     1068       -3     
  Misses         23       23              
  Partials       32       32              
Impacted Files Coverage Δ
src/sequelize/data-type/data-type-service.ts 84.61% <0.00%> (-1.10%) ⬇️
...ons/belongs-to-many/belongs-to-many-association.ts 92.30% <0.00%> (-0.29%) ⬇️
src/validation/length.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfba1e7...dbbc6d6. Read the comment docs.

- eslint doesn't support node10 anymore
Copy link
Contributor

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theoludwig theoludwig changed the title build(deps-dev): bump dev dependencies and resolve upgrade conflicts build(deps-dev): bump dev dependencies Feb 11, 2022
@theoludwig theoludwig merged commit f896a6f into sequelize:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants