Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popper v2 #127

Closed
the94air opened this issue Feb 27, 2020 · 5 comments
Closed

Popper v2 #127

the94air opened this issue Feb 27, 2020 · 5 comments

Comments

@the94air
Copy link

the94air commented Feb 27, 2020

Can we have support for Popper v2 as of the current package only support Popper v1.15.0

@pdevito3
Copy link

pdevito3 commented Mar 7, 2020

really should be updated to v2. Is this on the roadmap at all?

@the94air
Copy link
Author

the94air commented Mar 7, 2020

I don't think so. I doubt if it's maintained anymore. I ended up using the original library anyway ¯_(ツ)_/¯. And I think I like that I did that.

@RobinCK
Copy link
Owner

RobinCK commented Mar 7, 2020

I don't see any advantages in the new version popperjs
Anyway you can do PR

@atomiks
Copy link

atomiks commented Mar 8, 2020

I don't see any advantages in the new version popperjs

?

It's 1.5 kB smaller by default & tree-shakable, 38 bugs were fixed, the default behavior is far more intuitive, offsets rounding is more accurate with no blurry issues, the API is cleaner and easier to use (modifier merging by name, adheres better to HTML spec), plus some useful features were added like offset taking a function and the detectOverflow utility to create modifiers like size that can apply a max-height to the popper to fit it in the viewport when flipping also fails.

@curtisbelt
Copy link

Would appreciate testing and feedback here! #133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants