Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the output of si_to_od be it own class? #6

Open
Nowosad opened this issue Apr 18, 2022 · 1 comment
Open

Should the output of si_to_od be it own class? #6

Nowosad opened this issue Apr 18, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Nowosad
Copy link
Collaborator

Nowosad commented Apr 18, 2022

This way it would be impossible to provide a data with wrong structure to si_model().
@Robinlovelace
Copy link
Owner

Possibly but not a priority IMO. If it were to be a class we could build on an OD class, e.g. as discussed here: ITSLeeds/od#20

@Nowosad Nowosad added the enhancement New feature or request label Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Robinlovelace @Nowosad