fix logic issue

luau-lang · Nov 9, 2021 · 80ff5e3 · 80ff5e3
1 parent a81fecb
commit 80ff5e3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -82,4 +82,4 @@ jobs:
     - uses: actions/upload-artifact@v2
       with:
         name: coverage
-        path: coverage
+        path: coverage
diff --git a/CLI/Repl.cpp b/CLI/Repl.cpp
@@ -204,6 +204,9 @@ extern "C"
 {
     const char* executeScript(const char* source)
     {
+        // static string for caching result (prevents dangling ptr on function exit)
+        static std::string result;
+
         // setup flags
         for (Luau::FValue<bool>* flag = Luau::FValue<bool>::list; flag; flag = flag->next)
             if (strncmp(flag->name, "Luau", 4) == 0)
@@ -221,9 +224,8 @@ extern "C"
 
         // run code + collect error
         std::string error = runCode(L, source);
-
-        // output error(s)
-        static std::string result = error;
+        result  = error;
+
         if (error.length())
         {
             return result.c_str();