You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that, in the first example, the cloned ty is not persistent and so doc symbols get generated for it, but because i've added the declare function newFoo() in the second example, the cloned ty is already persistent, so it fails to add a doc symbol
The text was updated successfully, but these errors were encountered:
* #719
* Improved `Failed to unify type packs` error message to be reported as
`Type pack 'X' could not be converted into 'Y'`
* #722
* 1% reduction in executed instruction count by removing a check in fast
call dispatch
* Additional fixes to reported error location of OOM errors in VM
* Improve `math.sqrt`, `math.floor` and `math.ceil` performance on
additional compilers and platforms (1-2% geomean improvement including
8-9% on math-cordic)
* All thrown exceptions by Luau analysis are derived from
`Luau::InternalCompilerError`
* When a call site has fewer arguments than required, error now reports
the location of the function name instead of the argument to the
function
* #724
* Fixed#725
Co-authored-by: Arseny Kapoulkine <arseny.kapoulkine@gmail.com>
Co-authored-by: Andy Friesen <afriesen@roblox.com>
* luau-lang/luau#719
* Improved `Failed to unify type packs` error message to be reported as
`Type pack 'X' could not be converted into 'Y'`
* luau-lang/luau#722
* 1% reduction in executed instruction count by removing a check in fast
call dispatch
* Additional fixes to reported error location of OOM errors in VM
* Improve `math.sqrt`, `math.floor` and `math.ceil` performance on
additional compilers and platforms (1-2% geomean improvement including
8-9% on math-cordic)
* All thrown exceptions by Luau analysis are derived from
`Luau::InternalCompilerError`
* When a call site has fewer arguments than required, error now reports
the location of the function name instead of the argument to the
function
* luau-lang/luau#724
* Fixedluau-lang/luau#725
Co-authored-by: Arseny Kapoulkine <arseny.kapoulkine@gmail.com>
Co-authored-by: Andy Friesen <afriesen@roblox.com>
For a definition file like so:
a documentationSymbol is correctly attached to
Foo
as@test/globaltype/Foo
However, if I then make the file like the following
Foo
no longer gets any documentation symbols attached to itself or its propsTaking a deeper look, it seems to be related to the code at https://github.com/Roblox/luau/blob/54324867df2d91bc527f6de9217b05c3a9ae235f/Analysis/src/Frontend.cpp#L163-L181 and
generateDocumentationSymbols
The generate doc symbols function doesn't add symbols if the type is
persistent
It seems that, in the first example, the cloned ty is not persistent and so doc symbols get generated for it, but because i've added the
declare function newFoo()
in the second example, the cloned ty is already persistent, so it fails to add a doc symbolThe text was updated successfully, but these errors were encountered: