Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luau precompiled Ubuntu binary uses very new glibc version. #773

Closed
memcorrupt opened this issue Dec 6, 2022 · 3 comments
Closed

Luau precompiled Ubuntu binary uses very new glibc version. #773

memcorrupt opened this issue Dec 6, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@memcorrupt
Copy link

Since #769 was merged, Luau's GitHub actions script now builds the Ubuntu executable with a glibc version of at least 2.34. This effectively cuts the precompiled build from being used on any systems older than Ubuntu 22, unless obtaining glibc outside of the default repositories.

Sample output:

# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.2 LTS
Release:        20.04
Codename:       focal
# ./luau
./luau: /lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by ./luau)
./luau: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ./luau)
./luau: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by ./luau)

Since Ubuntu 22 was released this year, this limits the scope of users who can use the precompiled binary.
@memcorrupt memcorrupt added the bug Something isn't working label Dec 6, 2022
@memcorrupt
Copy link
Author

This is caused by GitHub Actions slowly rolling out a change of ubuntu-latest from ubuntu-20.04 to ubuntu-22.04 (see actions/runner-images#6399). It is most likely the cause of the initial issue of clang++10 being missing in that PR.

@vegorov-rbx
Copy link
Collaborator

Thank you, I'll try switching to ubuntu-20.04 in our Github Actions. And back to clang++10 for coverage because 11 has regressions in coverage information.

@ondohotola ondohotola mentioned this issue Dec 10, 2022
Closed
@vegorov-rbx vegorov-rbx mentioned this issue Jan 6, 2023
Merged
vegorov-rbx added a commit that referenced this issue Jan 6, 2023
@vegorov-rbx
Keep using ubuntu-20.04 in GitHub Actions (and clang++-10 in coverage) (
685ca02 
#795)

### Problem
ubuntu-latest was updated to 22.04 which removes clang++-10 we used for
coverage stats and creates a pre-compiled binary that requires a glibc
upgrade #773

### Solution
Pin to ubuntu-20.04 using multi-value matrix configurations.
In coverage configuration, we use clang++-10 once again.
@vegorov-rbx
Copy link
Collaborator

Latest release binaries should be build on Ubuntu 20.04

RomanKhafizianov pushed a commit to RomanKhafizianov/luau that referenced this issue Nov 27, 2023
@vegorov-rbx
Keep using ubuntu-20.04 in GitHub Actions (and clang++-10 in coverage…
71e5891 
…) (#795)

### Problem
ubuntu-latest was updated to 22.04 which removes clang++-10 we used for
coverage stats and creates a pre-compiled binary that requires a glibc
upgrade luau-lang/luau#773

### Solution
Pin to ubuntu-20.04 using multi-value matrix configurations.
In coverage configuration, we use clang++-10 once again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@memcorrupt @vegorov-rbx