Fix CLI analysis reporting wrong file names

[Rerumu]

Fix #144

Regarding (#144 (comment)):

We should check frontend.isDirty(name) in analyzeFile before running type checking. This will automatically skip redundant checks for dependent modules when we encounter them again in recursive traversal

At about which point should this check happen? From my understanding frontend.check(name) does type checking, so should the function just exit early reporting no errors?

Additionally, reportWarning at a glance has the same undesirable behavior that reportError did, but I opted to wait and ask if this is intentional before changing it also.

[zeux]

At about which point should this check happen? From my understanding frontend.check(name) does type checking, so should the function just exit early reporting no errors?

I believe Frontend propagates errors for dependent modules for type checking, so .check will return dependent module info, but lint doesn't - so if the module is not dirty, we should skip .check but still run .lint.

[Rerumu]

If that's correct then that just leaves whether reportWarning should be changed to respect module names too.

[zeux]

Not sure what you mean - LintWarning doesn't carry a module name?

In general this silent error propagation business is pretty weird and it would probably be better to refactor the Frontend to not do that, and instead to expose dependent modules to the caller so that the caller can aggregate errors if need be. However, this would change the Frontend interface and we have internal tools that rely on the specific behavior, so we'd need to do that internally separately.

[Rerumu]

My bad on that, I was looking at TypeError not LintWarning. I think the issue is solved then.

[zeux]

Thanks!