RFC: Write-only properties #79
Merged
+179
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegorov-rbx
reviewed
Oct 7, 2021
vegorov-rbx
reviewed
Oct 7, 2021
vegorov-rbx
reviewed
Oct 7, 2021
vegorov-rbx
reviewed
Oct 7, 2021
Co-authored-by: vegorov-rbx <75688451+vegorov-rbx@users.noreply.github.com>
vegorov-rbx
reviewed
Oct 11, 2021
vegorov-rbx
reviewed
Oct 11, 2021
vegorov-rbx
reviewed
Oct 11, 2021
Comment on lines
+149
to
+150
| If we infer such types, we may wish to present them differently, for | ||
| example TypeScript allows both a getter and a setter. |
There was a problem hiding this comment.
So are we going to infer such types? This part of the design is a bit vague.
I can see how we can end up with such a type if the user uses intersection on two tables like these, but I'm not sure how will the inference create such an intersection by itself.
There was a problem hiding this comment.
In the implementation, I was thinking we'd use type normalization so we'd end up with a property having an optional read type and an optional write type. So inference would be able to create these types.
vegorov-rbx
reviewed
Oct 12, 2021
Co-authored-by: vegorov-rbx <75688451+vegorov-rbx@users.noreply.github.com>
vegorov-rbx
approved these changes
Oct 27, 2021
vegorov-rbx
added a commit
that referenced
this pull request
Apr 28, 2023
* Added a limit on how many instructions the Compiler can safely produce (reported by @TheGreatSageEqualToHeaven) C++ API Changes: * With work started on read-only and write-only properties, `Property::type` member variable has been replaced with `TypeId type()` and `setType(TypeId)` functions. * New `LazyType` unwrap callback now has a `void` return type, all that's required from the callback is to write into `unwrapped` field. In our work on the new type solver, the following issues were fixed: * Work has started to support #77 and #79 * Refinements are no longer applied on l-values, removing some false-positive errors * Improved overload resolution against expected result type * `Frontend::prepareModuleScope` now works in the new solver * Cofinite strings are now comparable And these are the changes in native code generation (JIT): * Fixed MIN_NUM and MAX_NUM constant fold when one of the arguments is NaN * Added constant folding for number conversions and bit operations * Value spilling and rematerialization is now supported on arm64 * Improved FASTCALL2K IR generation to support second argument constant * Added value numbering and load/store propagation optimizations * Added STORE_VECTOR on arm64, completing the IR lowering on this target
RomanKhafizianov
added a commit
to RomanKhafizianov/luau
that referenced
this pull request
Nov 27, 2023
* Added a limit on how many instructions the Compiler can safely produce (reported by @TheGreatSageEqualToHeaven) C++ API Changes: * With work started on read-only and write-only properties, `Property::type` member variable has been replaced with `TypeId type()` and `setType(TypeId)` functions. * New `LazyType` unwrap callback now has a `void` return type, all that's required from the callback is to write into `unwrapped` field. In our work on the new type solver, the following issues were fixed: * Work has started to support luau-lang/luau#77 and luau-lang/luau#79 * Refinements are no longer applied on l-values, removing some false-positive errors * Improved overload resolution against expected result type * `Frontend::prepareModuleScope` now works in the new solver * Cofinite strings are now comparable And these are the changes in native code generation (JIT): * Fixed MIN_NUM and MAX_NUM constant fold when one of the arguments is NaN * Added constant folding for number conversions and bit operations * Value spilling and rematerialization is now supported on arm64 * Improved FASTCALL2K IR generation to support second argument constant * Added value numbering and load/store propagation optimizations * Added STORE_VECTOR on arm64, completing the IR lowering on this target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An RFC for a write-only access marker on properties in table types.