Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to .Net Core 3.0 #35

Closed
kellyprankin opened this issue Nov 17, 2019 · 2 comments
Closed

Update to .Net Core 3.0 #35

kellyprankin opened this issue Nov 17, 2019 · 2 comments

Comments

@kellyprankin
Copy link

I've updated the project for C# to .Net Core 3.0.

Are you interested in me opening a pull request? The changes are honestly very minimal to the code.

I'd need to update the Sample Project as well, but I first wanted to see if you would accept the PR or not.
@nubi86
Copy link
Collaborator

nubi86 commented Nov 18, 2019

Yes, please go ahead! Thank you.

@nubi86 nubi86 closed this as completed Dec 22, 2019
@kellyprankin
Copy link
Author

@nubi86 Hello, I think I've completed it. I am going to open a PR now.

@kellyprankin kellyprankin mentioned this issue Dec 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating RoboDK for C# to .Net Core 3.0 kellyprankin/RoboDK-API
2 participants
@kellyprankin @nubi86