Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO & Basic: TradeBox and OrderPage functional components. #303

Closed
Reckless-Satoshi opened this issue Oct 24, 2022 · 1 comment · Fixed by #315
Closed

PRO & Basic: TradeBox and OrderPage functional components. #303

Reckless-Satoshi opened this issue Oct 24, 2022 · 1 comment · Fixed by #315
Assignees
Labels
⚡Eligible for Sats ⚡ This issue or pull request rewards bitcoin enhancement 🆙 New feature or request

Comments

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Oct 24, 2022

This is an excerpt of main thread for RoboSats PRO #177 (comment)

We need to turn the current /src/components/TradeBox into a reusable functional component that makes use of the new Trade type /src/models/trade.model.ts (read above). This component is currently used on the OrderPage of RoboSats Basic, therefore this work will be useful for both frontends.

Refactoring this component into a more reusable functional component needs of also turning the OrderPage into a functional component. The new TradeBox has to be wrapped into a simple widget for use in RoboSats Pro. These two components are pretty massive and composed themself of many little pieces that can be turned into standalone components (for example, the TradeSummary was already turned into /src/components/TradeBox/TradeSummary.tsx).

Turning both, the OrderPage and the TradeBox into functional components and building the Trade widget is rewarded with 2M Sats ⚡ drop a comment if you want to be assigned.

@Reckless-Satoshi
Copy link
Collaborator Author

After finishing the new Navigation Bar I will slowly start to work on this task. If anyone is interested on taking this task I am happy to jump into something else. See live progress in PR #309 . Feel free to jump in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡Eligible for Sats ⚡ This issue or pull request rewards bitcoin enhancement 🆙 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant