Add app termination

[emargareten]

Is your feature request related to a problem? Please describe.
Some events only dispatch after app terminated / object destruction

Describe the solution you'd like
Add a simple $app->terminate() (or $kernal->terminate($input???, $status???)) in tinker_run.php after execution.

[Roboroads]

Does normal tinker do this?

[emargareten]

normal tinker never ends

[laserhybiz]

This is one of the stuff I hate in tinker, sometimes I have to manually call __destruct for things to work.

Also see https://github.com/laravel/telescope/issues?q=terminate+tinker

[Roboroads]

Normal tinker stops when you type "q" or "exit" - if that does what you want it to do, then the latest update (2.3.4) will do exactly that.

If not: I can add an option to the settings to enable termination or not, since I try to mimic actual tinker as close as possible.

[emargareten]

q and exit throws the BreakException I don't think it terminates the application.

[Roboroads]

Laravel Tinker-2.4.0.zip
Does this work? (Turn it on in the tinker project settings)

[emargareten]

@Roboroads does this zip include the latest changes? I'm still using 2022.1

[Roboroads]

@emargareten This zip contains #170

[emargareten]

Can I use it with 2022.1

[Roboroads]

Yes but docker interpreters won't work

[emargareten]

@Roboroads works great 👍

I did notice that without that setting I get an additional Exit: Tinker execution finished. in the output

[Roboroads]

Laravel Tinker-2.4.0.zip
With this one too?

I try to make sure there is no extra => null and Exit: *****

[emargareten]

no, now it's fine.
but.. now I see dump() doesn't work, not sure which change caused it

[Roboroads]

I don't have this issue

[emargareten]

@Roboroads It does work, I think you can go ahead with this.

I do have another issue I think it started in version 2.3.4, sometimes the output displays only partially or doesn't display at all. (I might have had this issue on rare occasions before but now it happens like 50% of the time)

[Roboroads]

Maybe you should create a new issue for that problem and see if other people have the same problem since I don't have it it and need a way to reproduce it to be able to fix it 🥲

[Roboroads]

Will be in 2.4.0

[Roboroads]

2.4.0 will be available this week after JB accepts it, which includes this issue.