-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot be used with Electron on Windows #705
Comments
I haven't used rclnodejs with Electron, I think @koonpeng has some experiences with Electron env, @koonpeng would you please have a look at this issue? Have you ever met sort of the error? Some comments, hope it helpful
I don't think it could be workable with nodejs build, as you saw
What's the header missed? Is it ROS2 headers or what else?
Can you find the |
There is a bug in the current version of electron which causes rclnodejs to not work, the fix is currently scheduled in v11 beta. Also, if you are loading rclnodejs in the renderer process you need to disable renderer reuse (there's a flag somewhere in electron api). This is because rclnodejs is not "context-aware" and reusing the same process can cause unexpected behaviours. That being said, the error "rclnodejs.node is not a module" may be caused by some problems in the compilation process. You can start by checking if the file exists and see if there is any error messages during the compilation. |
Thanks for @koonpeng 's quick explanation, that's helpful!
I think we could improve this? |
Thank you for your replies. I will keep you posted about the issue, soon I'll update this issue thread. |
@koonpeng @fstojanovic does Thanks all! |
Hi @fstojanovic, are you able to resolve this issue |
It would appear that it is not possible to run with Electron on Windows.
When run if built for node, the following message pops up :
When I try to rebuild it for Electron using electron-rebuild, the build always fails, due to missing headers and dependencies. Once I manually resolve all those errors and it finally builds, running it for electron gives : "rclnodejs.node" is not a module.
When run for Node, without Electron, it works as expected.
The text was updated successfully, but these errors were encountered: