Document glob #276
Merged
Document glob #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting and examples
|
Your changes do describe the way these parameters currently work. Thanks for adding the documentation! The launch files we ship have been changed to include the default values your example mentions, which might be worth mentioning. I've also been thinking that it would be nice to have an option to deactivate the globbing mechanism altogether if performance is more of a concern than security, but that's probably a discussion for another time. |
|
I also think it's good idea to remind people to whitelist the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change introduced by PR #238
This change now requires all rosapi users to configure their globs to allow any topic/service/param information to be returned.
I've added a README which documents these new parameters along with two example launch configurations.
Please let me know if I've understood this feature correctly.
@mastereric @T045T