Fixed action_servers filter to allow more than one namespace #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonl
approved these changes
Dec 8, 2017
|
Thanks for the help. @Behery |
|
And thanks for the patch @milesial :) |
Behery
pushed a commit
to Behery/rosbridge_suite
that referenced
this pull request
Jan 9, 2018
…bTools#305) * Modified action_servers filter to detect topics with more than one namespace * Fixed to return the full namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The service
/rosapi/action_serversuses a filter function on topic names to detect action servers.Problem
This function worked only with topics of type
/namespace/goal, with only one namespace.Fix
It is now capable of detecting for example
/ns1/ns2/server/goal(when all goal, success, cancel, feedback and status topics are alive, of course).The service returns an array of the full namespaces,
/ns1/ns2/serverbeing one of them here for example