message_conversion: create stand-alone object inst #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catching the ROSInitException allows to create object instances without an initialized ROS state
jihoonl
requested changes
Jan 19, 2018
| if rostype in ros_header_types: | ||
| inst.stamp = rospy.get_rostime() | ||
| except rospy.exceptions.ROSInitException as e: | ||
| rospy.logdebug("Not substituting the correct header time: %s" % e) |
There was a problem hiding this comment.
rospy.logdebug will also fail because ros logger only works after rospy.init_node.
Can you provide me some context why you need this?
There was a problem hiding this comment.
The logging functions actually don't raise any exceptions if you call them before init_node, so this should be fine.
There was a problem hiding this comment.
This will be used to create message objects from offline data into a rosbag.
The logging function doesn't raise exceptions, it runs fine like this.
jihoonl
approved these changes
Feb 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching the ROSInitException allows to create object
instances without an initialized ROS state