Fixes passing of globs to proxy #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonl
requested changes
Aug 26, 2018
rosapi/scripts/rosapi_node
Outdated
| rospy.logdebug("List of allowed topic globs: "+str(topics_glob)) | ||
| topics = proxy.get_topics(topics_glob) | ||
| types = proxy.get_topics_types(topics, topics_glob) | ||
| rospy.logdebug("List of allowed topic globs: "+str(rosapi.glob_helper.topics_glob)) |
There was a problem hiding this comment.
This import may confuse. Could you remove import of topics_glob, service_glob, and params_glob?
jihoonl
approved these changes
Sep 29, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Globs were passed as empty lists from rosapi node to proxy.py
Also fixes #349