Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOS line endings #658

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

amacneil
Copy link
Member

Public API Changes
None

Description
Replace DOS line endings in several files with UNIX style.

@amacneil
Copy link
Member Author

@jtbandes is it safe to update these .srv files, or is that going to mess up something relying on md5sums?

Given their names, are they only used for testing?

@chfritz
Copy link

chfritz commented Oct 7, 2021

is it safe to update these .srv files, or is that going to mess up something relying on md5sums?

That should be fine. The md5sum is not computed from the file itself, but from a string that is constructed from the field names and types in a specific way that seems line ending agnostic. See, for instance, getMd5text() in rosnodejs. Meaning the md5sum should stay the same, but I haven't yet verified.

@amacneil
Copy link
Member Author

amacneil commented Oct 7, 2021

Great, thanks!

@amacneil amacneil merged commit 4a72999 into RobotWebTools:ros2 Oct 7, 2021
@amacneil amacneil deleted the adrian/dosends branch October 7, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants