Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit cleanly on SIGINT; remove sleep in test #667

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

jtbandes
Copy link
Member

The rosbridge_websocket and rosapi nodes now exit cleanly on ctrl-C. This makes the smoke test run faster when combined with some more targeted awaits in place of a sleep.

Copy link
Member

@amacneil amacneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jtbandes jtbandes merged commit 148ca59 into ros2 Oct 12, 2021
@jtbandes jtbandes deleted the jacob/clean-exit branch October 12, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants