Refactor smoke test to make WebSocket test harness reusable #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
commented
Nov 5, 2021
| from twisted.python import log | ||
|
|
||
| log.startLogging(sys.stderr) | ||
| sys.path.append(os.path.dirname(__file__)) # enable importing from common.py in this directory |
There was a problem hiding this comment.
There might be a better way to make this import work but I wasn't aware of one. For comparison, the rosbag2 tests use APPEND_ENV PYTHONPATH=${CMAKE_CURRENT_SOURCE_DIR} in their CMake rules, but we're using add_launch_test() in this package which doesn't seem to support the same flags. cc @emersonknapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Factor out the ROS and Twisted setup code from the smoke test, so we can reuse it for other tests in the future.