[694] update DurabilityPolicy api that are being deprecated #695
Conversation
|
LGTM once lint errors are fixed |
Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
flynneva
force-pushed
the
694-update-durabilitypolicy-api
branch
from
6042308
to
8fcf884
Compare
|
@defunctzombie just fixed the linter errors, let me know if there is anything else! |
|
friendly ping @defunctzombie or @jtbandes, this is a small change and would help anyone who is using |
|
@flynneva Am I correct in understanding that this fix will resolve the warning message - but that there is still a bug with incompatible QoS policies so messages are not received? |
|
@defunctzombie I think I mis-reported the issue originally. this PR addresses the warnings, but I think my original issue was due to starting the server incorrectly for ROS 2 |
|
@flynneva So with this change you no longer see a warning and are able to receive messages as expected over the websocket connection? |
|
@defunctzombie yes it just fixes the warning |
Signed-off-by: Evan Flynn evanflynn.msu@gmail.com
Public API Changes
None
Description
closes #694 to fix deprecation warnings for
DurabilityPolicyapi