Closes RobotWebTools/rosbridge_suite#721 #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amacneil
reviewed
Mar 10, 2022
| self.protocol.incoming(data.decode().strip('')) | ||
| else: | ||
| pass | ||
| if self.bson_only_mode: # is False |
There was a problem hiding this comment.
what is the is False comment referring to?
There was a problem hiding this comment.
That was just a little memory aid that I forgot to remove.
Thanks for the hint and the fast response. I removed in the newest commit.
|
Thanks! Added one comment, other than that looks good. |
amacneil
approved these changes
Mar 15, 2022
|
🙏 ty |
|
Hi @amacneil, As I commented in the issue: ros1 RosbridgeTcpSocket won't close and spins in an endless loop #721. Is there any plan to release these changes and update the release candidate package for ros 1 to fix this bug? Thanks! |
|
@jtbandes do you know how to do a release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
When the TCP connection of the client is closed, the Python Socket.recv(...) function returns an empty byte array. However, since the while loop checks for an empty string, the thread hangs in an infinite loop and causes the connection not to be disconnected.
Also added minor description changes for more clarity.
Fixes #721