hostname parameter is no longer converted as an int value #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achim-k
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
LGTM
This fixes the special case when running the rosbridge_websocket script directly instead of launching it via the launch file. When launching it via the launch file, the address is passed in as ros parameter to the script.
ros2 launch rosbridge_server rosbridge_websocket_launch.xml address:=0.0.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
Fix of #736
As mentioned in the documentation of tornado.netutil, hostname as to be a string, the conversion to an integer lead any usage of this parameter to an error
Description
#736