Interpret call_services_in_new_thread as boolean #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about all the commits for re-running linting. I didn't see a way to re-run them manually. |
achim-k
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
I ran into an issue with having the
call_serviceoperation run in its own thread (introduced in #847). This is not a huge deal as there is a configuration option to turn it off.However, changing the value of
call_services_in_new_threadparameter in therosbridge_websocket_launch.xmlhas no effect on whether or not that functionality is used.The issue is the parameter object always evaluates to
Trueinstead of evaluating the value of the parameter object (which can be interpreted as a string, double, bool, etc.). This change explicitly specifies how it should be interpreted which is probably what was intended when the parameter was introduced.