bugfix: topic list crashes if no topics are available #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is due to the function expecting an object unpackable to 2 iterables, but an empty iterable is returned if no topics are available. This happens only when using glob, which might have been the reason why this bug was not caught earlier.
|
@achim-k Sorry to ping you, can you review this pr (and others too)? |
achim-k
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thank you for the patch, I confirmed that it fixes the problem
As a side note, you might be interested in foxglove_bridge as a more maintained alternative to rosbridge
|
@achim-k Will definitely check, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
This is due to the function expecting an object unpackable to 2 iterables, but an empty iterable is returned if no topics are available.
This happens only when using glob, which might have been the reason why this bug was not caught earlier.