Wrap non-repo installs in installed state checks #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to do version checks and upgrades for non-repo installs.
This way we won't re-download the source file repeatedly if Chef's cache is cleared and the package is already installed. This'll also help enable upgrade actions for non-repo installs. Repo installs are already clean repo + package Chef resources, so they can still be left to do their thing.
hartmantis
force-pushed
the
jdh-upgrade-pt2
branch
from
fe4417c
to
d19c894
Compare
hartmantis
force-pushed
the
jdh-upgrade-pt2
branch
2 times, most recently
from
cf6aa27
to
f87319e
Compare
hartmantis
force-pushed
the
jdh-upgrade-pt2
branch
from
f87319e
to
2d62d89
Compare
This should restore support for Fedora, where YUM's existence and functionality is not guaranteed.
hartmantis
force-pushed
the
jdh-upgrade-pt2
branch
from
2d62d89
to
f60e706
Compare
Otherwise the homebrew::default recipe causes "stack too deep" errors when running ChefSpec on non-OS X platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With code to find the currently installed version on each supported platform. This will allow implementation of upgrade actions for non-repo installs and keep non-repo installs from re-downloading package files if they don't need to install anything.