Implement the :upgrade action for the :direct source on all platforms #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartmantis
force-pushed
the
jdh-upgrade-pt3
branch
from
bbc1790
to
4928f5b
Compare
hartmantis
force-pushed
the
jdh-upgrade-pt3
branch
from
4928f5b
to
4387834
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not sure what to do if the version property is overridden for an :upgrade action :\
Right now it would ignore the version property. It should probably either respect it or raise an error. Unit tests for it to raise an error are left in pending for now.