Skip to content
This repository has been archived by the owner on Dec 13, 2020. It is now read-only.

Add support for match setting in pep257. #3

Closed
wants to merge 3 commits into from

Conversation

codito
Copy link

@codito codito commented Aug 30, 2015

If a user specifies a match regex, pep257 is run on the file
only if it matches the match regex.

Documentation for match is available here: https://pep257.readthedocs.org/en/latest/usage.html

If a user specifies a match regex, pep257 is run on the file
only if it matches the match regex.

Documentation for match is available here: https://pep257.readthedocs.org/en/latest/usage.html
@Robpol86
Copy link
Owner

Wow sorry, forgot about this pr, my bad.

I feel this is out of scope for flake8-pep257. I let flake8 handle file discovery not pep257, I believe this is what's expected for flake8 extensions.

@codito
Copy link
Author

codito commented Nov 18, 2015

The use case that motivated this PR was to disable only pep257 for test files.

I had tried to solve it with flake8 config first, there is one challenge: if we use an ignore files pattern in flake8 configuration, it ignores all the flake8 checks on those files. Is there another alternate way?

@Robpol86
Copy link
Owner

I think the "right" way is to uninstall plugins. Plugins add functionality to flake8. flake8 and its plugins should act as one monolithic thing with a single configuration file that treats all supported files the same. It's like trying to disable some built-in pep8 errors for some files. It's not supported.

@Robpol86 Robpol86 closed this Nov 28, 2015
@codito
Copy link
Author

codito commented Nov 29, 2015

Thanks for clarification!

@codito codito deleted the config-match-support branch November 29, 2015 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants