Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send notifications for transfers that are still being uploaded #103

Closed
helrond opened this issue Oct 9, 2017 · 5 comments
Closed

Comments

@helrond
Copy link
Member

helrond commented Oct 9, 2017

Transfers should not be checked until they have been completely uploaded. For large transfers, a check is necessary to ensure the bag is not in the process of being transferred.

Checking while bags are still being transferred results in incorrect error messages and failure reports.

@helrond
Copy link
Member Author

helrond commented Oct 9, 2017

use lsof to determine if file(s) are open?

We do not need to account for large transfers either with special notification messages or in the UI.

@helrond
Copy link
Member Author

helrond commented Oct 17, 2017

Fix in 667bf5b appears to hold processing if any file in uploads/ directory is open, which will likely create huge processing backlogs. This also has implications for email notification (delivery is delayed because processing is stopped).

Desired behavior is to process all bags not containing open files.

@helrond
Copy link
Member Author

helrond commented Oct 17, 2017

Additionally, if the upload of a large bag fails, this blocks all processing indefinitely.

@helrond
Copy link
Member Author

helrond commented Oct 17, 2017

Disregard two comments above - they represent a misunderstanding of the issue, which was actually cased by an unserialized bag with an illegal filename.

@helrond
Copy link
Member Author

helrond commented Oct 18, 2017

This is currently working!

@helrond helrond closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant