Saves metadata from bag-info.txt to application #133
Conversation
project_electron/orgs/models.py
Outdated
| bagit_profile_identifier = models.URLField() | ||
|
|
||
| @classmethod | ||
| def save_metadata(cls, metadata, archive=None): |
There was a problem hiding this comment.
- This would be more useful as a method of Archives just like get_bag_data should be a save_bag_data, that way you don't need to expose another object, and prevents class method.
- also, foreign key shouldn't be blank or null
There was a problem hiding this comment.
-And if logic needs to be in try/catch then return bool so code can react to it.
…d makes BagInfoMetadata.archives non-nullable
|
This is ready for another look! |
There was a problem hiding this comment.
@helrond I'll send you dump of the database that you'd be able to apply migrations too successfully (ideally what will happen when we go live)
Also, I made this a part of the ERROR Routine so you'll have to add BIERR to the ecodes..
|
@dboutmybizness your changes look good to me. As I was testing, I discovered a host of problems that occur when the bag metadata is saved before validation is complete, so I have moved that function down in the |
|
@helrond are you working on changes here? |
|
@dboutmybizness I am done with my work on this PR, unless you see issues that need to be addressed. |
Adds models for metadata in
bag-info.txt, as per #125. Started to add this data into views, but leaving most of that work for other PRs.This is branched from #132, so that should be merged first.