Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] share profile with property filter sharing all properties after share pressed once #98

Open
Nabhag8848 opened this issue Apr 5, 2023 · 0 comments · May be fixed by #100
Open
Labels
bug Something isn't working

Comments

@Nabhag8848
Copy link
Contributor

Description:

  • When running /github me we have the share profile button when sharing the profile for the second time with filter property (any number of property) its sharing whole profile instead of that only filter properties. For this we have planned to instead close the modal once the share button is clicked.

Steps to reproduce:

  1. run `/github me` and click share profile
  2. filter property and `press share` to chat button two times
  3. check the second response to channel.

Expected behavior:

  • Close the modal once its shared thus to reduce complexity and as user would never won't to share the profile for the second time in the same channel at a same time.

Actual behavior:

  • sharing the profile for the second time with filter property (any number of property) its sharing whole profile instead of that only filter properties.
    BugIssue
@Nabhag8848 Nabhag8848 added the bug Something isn't working label Apr 5, 2023
@Nabhag8848 Nabhag8848 linked a pull request Apr 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant