Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Comments don't support pagination #75

Closed
JeffreytheCoder opened this issue Mar 23, 2024 · 4 comments · Fixed by #76
Closed

[Bug] Comments don't support pagination #75

JeffreytheCoder opened this issue Mar 23, 2024 · 4 comments · Fixed by #76
Assignees
Labels
bug Something isn't working

Comments

@JeffreytheCoder
Copy link
Contributor

What happened?

Our App doesn't support pagination of comments. The current implementation fetches Notion's Comment API, which returns max 100 comments.

We want support pagination comments, like for pages & DBs, which have an existing issue #38 in progress.

Steps to reproduce

View comments of a Notion page with 100+ comments

Relevant ScreenShots

No response

Version

v6.6.5

What browsers are you seeing the problem on?

Chrome

@JeffreytheCoder JeffreytheCoder added the bug Something isn't working label Mar 23, 2024
@JeffreytheCoder
Copy link
Contributor Author

Working on it

@Nabhag8848
Copy link
Collaborator

Hey @JeffreytheCoder Are you still working on this ? Let us know if you stuck or have any questions

@JeffreytheCoder
Copy link
Contributor Author

Yes @Nabhag8848 I'm waiting for #59 to go through so I can keep the code style consistent and learn from your reviews there

@Nabhag8848
Copy link
Collaborator

Nabhag8848 commented Apr 8, 2024

Thanks @JeffreytheCoder ! just merged #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants