Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Comment on Notion Page #9

Closed
8 tasks
Nabhag8848 opened this issue Jun 7, 2023 · 0 comments · Fixed by #19
Closed
8 tasks

[Feat] Comment on Notion Page #9

Nabhag8848 opened this issue Jun 7, 2023 · 0 comments · Fixed by #19
Labels
enhancement New feature or request

Comments

@Nabhag8848
Copy link
Collaborator

Nabhag8848 commented Jun 7, 2023

What do we need?

Previously Proposed Feature Workflow

  • The /notion comment command can be useful for teams who use Notion as their secondary collaboration tool. This command enables users to comment on Notion pages directly from Rocket.Chat, making it easier to collaborate and share feedback without having to switch between different applications.

  • When the user will run /notion comment it will open up the modal having the icon and name of the connected workspace with the dropdown where the user can search for the page and a multiline input field to leave a comment.

image

  • Furthermore, Comments on a page support rich text formatting such as bold, italic, code, strikethrough, and more. We will be handling all of these as the multiline input field supports markdown.

  • When User clicks on Share button it will create the Comment in Notion Page and there will be comment as Message in RocketChat Channel. Now when the user reply in that thread the comment will be automatically created in Notion but there are security concerns with this.

Limitation and Security Concern for the Previously Proposed Feature of Workflow

  • user can only initiate the comments from RocketChat is not able to see the comments made within the Notion. This make feature unusable.
  • As user might not need to create a comment everytime in pages when replying to thread and there would be a problem when the user edits and deletes the message as there is no way to update / delete the comment in Notion with API.

Current Proposed Changes

  • Now We Will have a Following:

  • When User runs command /notion comment it will trigger a block with the search page dropdown where user can search for page and Multline Input where user can leave a comment which also supports markdown.

  • when user clicks on Comment On Page it will create the Comment in Notion.

  • After Selecting the Page when User Clicks on the View Comments. It will Open Up the Contextual bar from Side with PageName as Header. And will show up all the Unresolved Comments. Each Comment will have associated UserName and Its Profile with the Created time.

  • In Case If there are Comments created in Notion while we are using the feature. User Can Click On Refresh For New Comments which will update the Contextual bar to have the New Comments.

image

It Solves Previous Limitation:

  • Now we can See all the Comments which were created from RocketChat and in Notion.
  • We can Comment From RocketChat in Specific Page in flow of our conversation in Rocketchat
  • We Can Refresh for Getting New Comments from Notion.

Limitation:

  • We won’t be able to get the discussion Comment / Comment which was made on Block [in between the pages] or Inline Element.
  • Technical Reason: As it supports the BlockId we can’t get that Specific BlockId in Which the Comment is created. copy pasting that blockId and using that block in RocketChat loses the key fundamental problem we are solving.

Acceptance Criteria

  • Register Comment Param and Have an Action Button in Message Box.
  • CreateCommentContextualBar Having SearchPage Component and MultiLine Input.
  • Handle Empty InputBlocks With ViewErrors.
  • Handle Refresh Of Comment.
  • Handle MarkDown Comment
  • create retrieveCommentsOnPage method in NotionSDK
  • create retrieveAllUsers, retrieveUser method in NotionSDK
  • create CommentOnPage method in NotionSDK

Relevant ScreenShots

No response

Further Comments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant