Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notification 'hasReply' option for Mac #1128

Closed
2 tasks done
jeph-with-an-f opened this issue Mar 7, 2019 · 0 comments
Closed
2 tasks done

notification 'hasReply' option for Mac #1128

jeph-with-an-f opened this issue Mar 7, 2019 · 0 comments
Labels
feat: notifications plat: osx type: bug
Milestone
2.15.1

Comments

@jeph-with-an-f
Copy link

jeph-with-an-f commented Mar 7, 2019 •
edited by tassoevan

When getting a message notification on Mac, it seems the reply in notification option is no longer working.

There was recently a change in the code for the notifications, seems like it is now using the electron api for notifications. Looking at the documentation here: https://electronjs.org/docs/api/notification it shows that there is an option 'hasReply' boolean that can be passed in to enable the inline reply.

My Setup

  • Operating System: MacOS Mojave, 10.14.3
  • App Version: 2.15
  • Installation type: dmg, downloaded from latest release
  • I have tested with the latest version
  • I can simulate the issue easily

Description

screen shot 2019-03-07 at 10 20 40 am

Current Behavior

The notifications show as the attached screenshot.

Expected Behavior

The notifications should show with the option to reply inline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: notifications plat: osx type: bug
Projects
None yet
Milestone
2.15.1
Development

No branches or pull requests
2 participants
@tassoevan @jeph-with-an-f