Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Download Manager #1700

Merged
merged 77 commits into from Dec 9, 2020
Merged

feat: Download Manager #1700

merged 77 commits into from Dec 9, 2020

Conversation

TaimurAzhar
Copy link
Contributor

@TaimurAzhar TaimurAzhar commented Aug 30, 2020 •
edited

GSOC 2020 Desktop Manager For Rocket.Chat Desktop

Aug 30, 2020

Describe my work briefly

  • Create a feature-rich download manager with all the basic tools to track and manage downloads.
  • Use Rocket.Chat fuselage UI libraries.

What I did

  • Created a new page in the Rocket.Chat desktop application
  • Created shortcuts and menu items for the page.
  • Caught downloads and tracked and displayed information in as a scrollable list.
  • Added Progress tracking to downloads list so the percentage finished is tracked in realtime.
  • Added estimated network speed and estimated time to download.
  • Created Alternative minimalistic compact UI for downloads list.
  • Created Filters for the File type, filename, source server.
  • Ability to pause, resume, and cancel a download.
  • Created filter for download status such as Paused, Cancelled.
  • Add feature to retry canceled downloads.
  • Added show in folder and copy download Url features.

TODO

  • Implement badges for number of unseen finished downloads.
  • Create a toast with some popup sound that allows a user to know when a download is finished.

TaimurAzhar and others added 30 commits May 3, 2020 21:39
@TaimurAzhar
TrayIcon show and hide on focus
2388ae6
@TaimurAzhar
downlads page created
4d12049
@TaimurAzhar
Merge branch 'new-page' into feat/new-page
5a709db
@TaimurAzhar
downloads icon and icon position
fb9c20b
@TaimurAzhar
title and subtitle
47b3888
@TaimurAzhar
basic download item
1ba42ed
@TaimurAzhar
download item ui rough
92929e3
@TaimurAzhar
progress-bar working
579c360
@TaimurAzhar
added search and select inputs
bb8f411
@TaimurAzhar
download-item-ui nearly done
65305fa
@TaimurAzhar
attach webcontent id to server
b9505a8
@TaimurAzhar
server title added to download
d5d1d33
@TaimurAzhar
insatlled electron-store
9f12425
@TaimurAzhar
download store initial
31b53c5
@TaimurAzhar
downloads list loading
fafd8da
@TaimurAzhar
cleaning up - checkpoint commit
ee28661
@TaimurAzhar
show in folder button
cac8dd2
@TaimurAzhar
Remove downloads autoclearing
53c9e90
@TaimurAzhar
currentServeUrl reset to normal
daa694f
@TaimurAzhar
pause, resume, cancel
637b2d4
@TaimurAzhar
search by filename filter
2f0eb09
@TaimurAzhar
server and filetype filters testing
c5d357c
@TaimurAzhar
all tabs working
13fc3aa
@TaimurAzhar
retry downloads
9525554
@TaimurAzhar
date headings and filter by filetype
8fdf3c6
@TaimurAzhar
fixing small eslint codechecks
f890371
@TaimurAzhar
basic compact view
ac0d82c
@ggazzo
Review
0cfb859
@ggazzo @TaimurAzhar
Review
26d1810
@TaimurAzhar
fix cancelled status bug
b11d639
@tassoevan tassoevan requested a review from a team August 30, 2020 22:40
@MartinSchoeler
Copy link
Contributor

Hello @TaimurAzhar ! I've commited some changes to the ui of the download manager, to follow Rocket.Chat's design for it.

Here is a preview of it

Screen Shot 2020-09-25 at 6 53 45 PM

Congrats on the GSOC project!

@tassoevan tassoevan changed the base branch from develop to master November 4, 2020 22:21
@tassoevan tassoevan added this to the 3.1.0 milestone Nov 10, 2020
@tassoevan tassoevan merged commit ac30ab3 into RocketChat:master Dec 9, 2020
@TibboddiT TibboddiT mentioned this pull request Apr 14, 2021
Closed
TibboddiT added a commit to TibboddiT/Rocket.Chat.Electron that referenced this pull request Apr 14, 2021
@TibboddiT
Fix tray show/hide actions
58c8838 
Revert use of focused state to determine window visibility from PR RocketChat#1700
Fix RocketChat#1935
This was referenced Apr 14, 2021
Closed
Merged
tassoevan pushed a commit that referenced this pull request Apr 19, 2021
@TibboddiT
fix: Tray icon toggle action (#2006)
4d50b80 
* Fix tray show/hide actions

Revert use of focused state to determine window visibility from PR #1700
Fix #1935

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: new feature
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TaimurAzhar @MartinSchoeler @tassoevan @ggazzo