Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set default server servers.json and Open server on click notification #2144

Merged
merged 11 commits into from Sep 6, 2021

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 6, 2021

Closes #ISSUE_NUMBER

Since we are sending/sharing all events cross main/render, every rocket.chat instance was asking for focus not being possible to identify which one is the correct. now only the instance that generated the notification will receive the 'CLICKED' event.

@ggazzo ggazzo requested a review from cazetto September 6, 2021 15:26
src/notifications/main.ts Outdated Show resolved Hide resolved
src/notifications/main.ts Outdated Show resolved Hide resolved
@ggazzo ggazzo merged commit b748b10 into master Sep 6, 2021
@ggazzo ggazzo deleted the default-server branch September 6, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants