Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Email-notifications] Do not allow to flood user inbox with emails #10000

Closed
jacekmusial opened this issue Mar 4, 2018 · 4 comments
Closed

Comments

@jacekmusial
Copy link

jacekmusial commented Mar 4, 2018

Description:

Currently every single message to offline users results in separate email.
It's the same when writing message in room with offline users.

By pressing any single letter and enter several times, we can result in multiple several emails to offline user. It is a issue when offline user have non-gmail email inbox, for instance like me at work, which cannot display all emails in one row.

I hate to say it, but there is potential of DDoS-like situation for internal company emails solution, because of this correlation 1 message -> 1 email.

Steps to Reproduce:

  1. Find offline user(s)
  2. Send him several private messages or even worse, send messages in room he is watching.

Expected behavior:

After X messages have been sent, Rocket now will accumulate rest of the messages for Y time and will send it in one email.
For instance, X = 5 messages, Y = 5 minutes

Actual behavior:

Direct email is being sent for every message/mention to offline user(s).

EDIT: Yay, I'm number 10000 issue. This is great project!

@c0fe
Copy link

c0fe commented Mar 4, 2018

Suggestion: There should be one email (with ability to turn off entirely) that notifies the particular user that there are missed messages. It should not accumulate messages at all since more messages can come after that email has been sent.

@theorenck
Copy link
Contributor

Hi @912d, we will evaluate you suggestion. But right now it is not on our top priorities. Thanks.

@maxvisser
Copy link

I suggest wait like 15 min before sending a mail and add every message missed as a digest.

@TwizzyDizzy
Copy link

@rocket-cat close

Closing this in favour of #6079 as the sentiment is the same.

Cheers
Thomas

@rocket-cat rocket-cat bot closed this as completed Mar 21, 2018
@theorenck theorenck removed this from the Mid-term milestone Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants