Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu in RTL isnt in place #10068

Closed
faziloub opened this issue Mar 9, 2018 · 13 comments · Fixed by #10428
Closed

Menu in RTL isnt in place #10068

faziloub opened this issue Mar 9, 2018 · 13 comments · Fixed by #10428
Projects
Milestone

Comments

@faziloub
Copy link

faziloub commented Mar 9, 2018

Description:

Server Setup Information:

  • Version of Rocket.Chat Server: 63
  • Operating System: ubuntu
  • Deployment Method(snap/docker/tar/etc):
  • Number of Running Instances:
  • DB Replicaset Oplog:
  • Node Version:
  • mongoDB Version:

Steps to Reproduce:

screenshot-open rocket chat-2018 03 09-04-53-00

@theorenck theorenck added this to the 0.64.0 milestone Mar 9, 2018
@TwizzyDizzy
Copy link

I'm not very familiar with RTL UIs, but to me that looks pretty much what I would expect. Can you elaborate on what "is not in place" means to you? :)

Cheers & Thanks
Thomas

@sparse91
Copy link

Hello
Is there any workaround for this bug? with CSS maybe?
thanks

@TwizzyDizzy
Copy link

Hi @IDanielBlake,

no offense intended, but: can we first agree on what's the actual bug here? ;)

Cheers
Thomas

@sparse91
Copy link

sparse91 commented Mar 11, 2018

When I click on my profile picture on right above corner (in RTL RC) menu opens outside of the screen. Just like the picture. sorry for my eng. Thanks

@TwizzyDizzy
Copy link

TwizzyDizzy commented Mar 11, 2018

Ah! I though this was some censoring for privacy. OK. Then I get it... thanks!

Cheers
Thomas

PS: Nope, I cannot help you.

@sparse91
Copy link

Now is there any fix with some css? I updated our Rocketchat and It's broken somehow. Can you help? Thank you so much

@efih
Copy link

efih commented Mar 12, 2018

same issue here

@sparse91
Copy link

sparse91 commented Mar 12, 2018

RC 0.62.2:
I tried some CSS but I'm not an expert. ltr direction made it better but messed up other menus. maybe there is a workaround. 0.64 milestone is a long time.
.rc-popover__content {
//right:30px !important;
//min-width:200px !important;
//max-width:300px !important;
//transform: translateX(-50%);
direction: ltr;
//transform: translateX(-10%);
//animation: unset !important;
}
.rc-popover {
//direction: ltr;
//width: 90% !important;
}

@theorenck
Copy link
Contributor

Thanks for inform the problem to us. @karlprieb, can you evaluate @IDanielBlake workaround?

@karlprieb
Copy link
Contributor

We need to fix the calc that we use to set the position when an user open the popover. It need to be done using JS. I can do that on the 0.64 release

@faziloub
Copy link
Author

thank you @karlprieb @theorenck

@theorenck theorenck added this to Desireable in 0.64.0 via automation Apr 9, 2018
@karlprieb karlprieb moved this from Desireable to Backlog in 0.64.0 Apr 9, 2018
@ggazzo ggazzo moved this from Backlog to Review/QA in 0.64.0 Apr 11, 2018
@karlprieb karlprieb moved this from Review/QA to Ready to merge in 0.64.0 Apr 11, 2018
0.64.0 automation moved this from Ready to merge to Done Apr 17, 2018
@sparse91
Copy link

This bug is come back in v3.13.3.

@ArielBenAharon
Copy link

Same here - reproducing the bug in v3.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
0.64.0
  
Done
Development

Successfully merging a pull request may close this issue.

7 participants