Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication that a user is not permitted to create public channels #10200

Closed
TheReal1604 opened this issue Mar 22, 2018 · 2 comments · Fixed by #10564
Closed

No indication that a user is not permitted to create public channels #10200

TheReal1604 opened this issue Mar 22, 2018 · 2 comments · Fixed by #10564
Assignees
Projects
Milestone

Comments

@TheReal1604
Copy link
Contributor

Description:

I revoked the permission to create public channels for certain user groups. The issue with this is, that there is no indicator that the user is not permitted to create a new public channel, the button is just not clickable. (and nothing happens)

Server Setup Information:

  • Version of Rocket.Chat Server: 0.62.2
  • Operating System: Ubuntu Server 16.04.4 LTS
  • Deployment Method(snap/docker/tar/etc): docker
  • Number of Running Instances: 3
  • DB Replicaset Oplog: YES

Steps to Reproduce:

  1. Revoke permission for users to create new public channels
  2. Try to create a new public channel

Expected behavior:

There should be a screen that says the user that he is not permitted to do so..

Actual behavior:

Nothing happens.

Relevant logs:

image

@TwizzyDizzy
Copy link

TwizzyDizzy commented Mar 23, 2018

Remark: the button to add a channel from directory view also seems to be impacted.

Adding a quote from there:

if I disable the creation of channels for some user group, the button to create the channel is not present in the main menu but it is still present in the Directory menu allowing a user to try to create the channel (but failing) and (worse for me) to see the entire list of users. I hope I explained it better.

@theorenck theorenck added this to the 0.65.0 milestone Apr 11, 2018
@theorenck theorenck added this to Desirable in May/2018 via automation Apr 20, 2018
@karlprieb
Copy link
Contributor

We will fix the private/public channel switch behavior on the Create new channel page, check for permissions to show the create channel button on Directory and create permissions to allow users to use the Directory feature.

@theorenck theorenck moved this from Desirable to Backlog in May/2018 Apr 30, 2018
@ggazzo ggazzo moved this from Backlog to Review/QA in May/2018 May 10, 2018
@ggazzo ggazzo self-assigned this May 10, 2018
@rodrigok rodrigok moved this from Review/QA to Ready to merge in May/2018 May 18, 2018
May/2018 automation moved this from Ready to merge to Done May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
May/2018
  
Done
6 participants