Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling AmazonS3.js #10289

Closed
logancodes opened this issue Apr 1, 2018 · 2 comments · Fixed by #10372
Closed

Error handling AmazonS3.js #10289

logancodes opened this issue Apr 1, 2018 · 2 comments · Fixed by #10372
Assignees
Milestone

Comments

@logancodes
Copy link

Description:

There is no error handling for the callback in get function(see line number 10 in AmazonS3.js)

File location: Rocket.Chat/packages/rocketchat-file-upload/server/config/AmazonS3.js

The code present in this file is duplicated from Googlestorage.js (Rocket.Chat/packages/rocketchat-file-upload/server/config/GoogleStorage.js).

It is important to include error handling implementation in AmazonS3 get function. This can be done by following the same error handling syntax in Googlestorage.js (line 10-13 in the picture)

codeduplication copy

@Hudell Hudell self-assigned this Apr 2, 2018
@logancodes
Copy link
Author

Hi @Hudell, we are actually working on fixing the issue. So you might not need to fix it. Thanks

@Hudell
Copy link
Contributor

Hudell commented Apr 2, 2018

Alright!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants